build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34946 )
Change subject: WIP: add src/mainboard/hp/spectre_x360_13t_ae000 port ......................................................................
Patch Set 26:
(10 comments)
https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/romstage.c:
https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 27: /* Do you really want me to make a header for this? trailing whitespace
https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 41: /* stock image around 0x007445A0 and 0x007A2C80 and 0x007BA120 trailing whitespace
https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 42: * around 0x007BA120 is probably where we have maps for different trailing whitespace
https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 84: trailing whitespace
https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 86: trailing whitespace
https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 87: memcpy(&mem_cfg->RcompResistor, rcomp_resistor, trailing whitespace
https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 89: trailing whitespace
https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 93: trailing whitespace
https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 98: trailing whitespace
https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 103: trailing whitespace