build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34946 ) Change subject: WIP: add src/mainboard/hp/spectre_x360_13t_ae000 port ...................................................................... Patch Set 26: (10 comments) https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/romstage.c: https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 27: /* Do you really want me to make a header for this? trailing whitespace https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 41: /* stock image around 0x007445A0 and 0x007A2C80 and 0x007BA120 trailing whitespace https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 42: * around 0x007BA120 is probably where we have maps for different trailing whitespace https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 84: trailing whitespace https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 86: trailing whitespace https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 87: memcpy(&mem_cfg->RcompResistor, rcomp_resistor, trailing whitespace https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 89: trailing whitespace https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 93: trailing whitespace https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 98: trailing whitespace https://review.coreboot.org/c/coreboot/+/34946/26/src/mainboard/hp/spectre_x... PS26, Line 103: trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/34946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie744cdccd3d110b4137e0b017b3f8497d23c0497 Gerrit-Change-Number: 34946 Gerrit-PatchSet: 26 Gerrit-Owner: Matt Parnell <mparnell@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Matt Parnell <mparnell@gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 05 Sep 2019 02:46:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment