Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33933 )
Change subject: soc/intel/icelake: Enable Audio FSP UPD based on devicetree HDA presence ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33933/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33933/1//COMMIT_MSG@7 PS1, Line 7: soc/intel/icelake: Enable Audio FSP UPD based on devicetree HDA presence I think 'Disable HDA based on devicetree" would be enough here.
It was previously always enabled, right?
https://review.coreboot.org/#/c/33933/1/src/soc/intel/icelake/romstage/fsp_p... File src/soc/intel/icelake/romstage/fsp_params.c:
https://review.coreboot.org/#/c/33933/1/src/soc/intel/icelake/romstage/fsp_p... PS1, Line 39: dev = pcidev_on_root(0x1f, 3); Place this below comment, empty line above comment to make it look pretty.