Attention is currently required from: Furquan Shaikh, Jakub Czapiga, Ricardo Quesada.
Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57869 )
Change subject: elogtool: add pytest for elogtool
......................................................................
Patch Set 5:
(1 comment)
File util/cbfstool/tests/conftest.py:
https://review.coreboot.org/c/coreboot/+/57869/comment/bd789f56_b37b6612
PS5, Line 7: pathlib.Path(__file__).parent
Will it be evaluated for this file, or each test file? […]
That won't work if Coreboot's a tarball downloaded from https://coreboot.org/downloads.html , right?
If we run git, we need a fallback if git is unavailable.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57869
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1241ad070d1c690c84f5ca61c0487ba27c2a287
Gerrit-Change-Number: 57869
Gerrit-PatchSet: 5
Gerrit-Owner: Ricardo Quesada
ricardoq@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jack Rosenthal
jrosenth@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jakub Czapiga
jacz@semihalf.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Ricardo Quesada
ricardoq@google.com
Gerrit-Comment-Date: Fri, 24 Sep 2021 15:42:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Gerrit-MessageType: comment