[coreboot-gerrit] New patch to review for coreboot: agesawrapper: Fix endless loop on bettong

[Ricardo Ribalda Delgado]

Ricardo Ribalda Delgado just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17924

-gerrit

commit 75e9650bce71630821c40e8bce0de23c7fcc90b2
Author: Ricardo Ribalda Delgado 
Date:   Tue Dec 20 10:08:45 2016 +0100

agesawrapper: Fix endless loop on bettong

AGESA AmdInitEarly() reconfigures the lapic timer in a way that
    conflicts with lapic/apic_timer.

This results in an endless loop when printk() is called after
    AmdInitEarly() and before the apic_timer is initialized.

This patches forces a reconfiguration of the timer after
    AmdInitEarly() is called.

Codepath of the endless loop:

printk()->
      (...)->
        uart_tx_byte->
          uart8250_mem_tx_byte->
            udelay()->
    	  start = lapic_read(LAPIC_TMCCT);
    	  	do {
    			value = lapic_read(LAPIC_TMCCT);
    		} while ((start - value) < ticks);
             [lapic_read returns the same value after AmdInitEarly()]

Change-Id: I1a08789c89401b2bf6d11846ad7c376bfc68801b
    Signed-off-by: Ricardo Ribalda Delgado 
---
 src/northbridge/amd/pi/agesawrapper.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/northbridge/amd/pi/agesawrapper.c b/src/northbridge/amd/pi/agesawrapper.c
index 8e16e75..420a694 100644
--- a/src/northbridge/amd/pi/agesawrapper.c
+++ b/src/northbridge/amd/pi/agesawrapper.c
@@ -15,6 +15,7 @@

#include <AGESA.h>
 #include <cbfs.h>
+#include <delay.h>
 #include <cpu/amd/pi/s3_resume.h>
 #include <cpu/x86/mtrr.h>
 #include <cpuRegisters.h>
@@ -107,6 +108,7 @@ AGESA_STATUS agesawrapper_amdinitearly(void)

AmdEarlyParamsPtr->GnbConfig.PsppPolicy = PsppDisabled;
    status = AmdInitEarly ((AMD_EARLY_PARAMS *)AmdParamStruct.NewStructPtr);
+	init_timer();
    if (status != AGESA_SUCCESS) agesawrapper_amdreadeventlog(AmdParamStruct.StdHeader.HeapStatus);
    AmdReleaseStruct (&AmdParamStruct);