Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38280 )
Change subject: mb/google/dedede: Add smihandler stub
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede...
File src/mainboard/google/dedede/smihandler.c:
https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede...
PS4, Line 34:
What about elog_gsmi_cb_mainboard_log_wake_source ?
I haven't enabled the support for ELOG yet. I am planning to add as a follow-up patch when we enable ELOG.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38280
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ab25888812bfb4578915e342b14355ccd15f5cc
Gerrit-Change-Number: 38280
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 09 Jan 2020 23:30:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin TerAvest
teravest@chromium.org
Gerrit-MessageType: comment