build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45474 )
Change subject: cpu/x86: Move SMI GSMI calls entry to a common place ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45474/1/src/drivers/elog/gsmi.c File src/drivers/elog/gsmi.c:
https://review.coreboot.org/c/coreboot/+/45474/1/src/drivers/elog/gsmi.c@137 PS1, Line 137: if (get_save_state_reg(RAX, apmc_node, &ax, sizeof(ax))) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45474/1/src/drivers/elog/gsmi.c@137 PS1, Line 137: if (get_save_state_reg(RAX, apmc_node, &ax, sizeof(ax))) please, no spaces at the start of a line