Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47602 )
Change subject: [WIP] lib/version: Remove .id section and id.S files ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47602/3/src/lib/Makefile.inc File src/lib/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/47602/3/src/lib/Makefile.inc@225 PS3, Line 225: bootblock-y += flash_id.c
Yeah, I don't think we would want to build further upon this, I think the separate CBFS file solutio […]
Dropped in favor of cbfs-file containing the strings.
https://review.coreboot.org/c/coreboot/+/47602/3/src/lib/flash_id.c File src/lib/flash_id.c:
https://review.coreboot.org/c/coreboot/+/47602/3/src/lib/flash_id.c@17 PS3, Line 17: union __ptr version;
Oh right, I forgot bootblocks were added as bins. […]
Dropped in favor of cbfs-file containing the strings.
https://review.coreboot.org/c/coreboot/+/47602/3/src/lib/flash_id.c@26 PS3, Line 26: .magic = 0xdeadbeef,
Different magic for sure, if implemented.
Dropped in favor of cbfs-file containing the strings.
https://review.coreboot.org/c/coreboot/+/47602/3/src/lib/program.ld File src/lib/program.ld:
https://review.coreboot.org/c/coreboot/+/47602/3/src/lib/program.ld@18 PS3, Line 18: #if !(ENV_X86 && ENV_BOOTBLOCK)
Did you read this as !ENV_X86 && ENV_BOOTBLOCK ? […]
If the only actual requirement is for the strings from (now removed) id.S files to appear uncompressed in the FMAP region COREBOOT, that is fulfilled with the separate cbfs-file added in a later patchset. To ever maintain the strings with a KEEP(*(.id)) seems waste of space to me now.