Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41612 )
Change subject: util: Add spd_tools to generate SPDs for TGL boards
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41612/10/util/spd_tools/intel/lp4x/...
File util/spd_tools/intel/lp4x/README.md:
https://review.coreboot.org/c/coreboot/+/41612/10/util/spd_tools/intel/lp4x/...
PS10, Line 65: SDRAM minimum cycle time
What about SDRAM maximum cycle time?
https://review.coreboot.org/c/coreboot/+/41612/8/util/spd_tools/intel/lp4x/g...
JEDEC spec says that max TCK should be 100ns. I see that all parts follow the same. I was thinking of keeping it as constant especially since we can't really encode 100ns in the SPD byte and instead have to stick to using 0xff i.e. 31.875ns.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41612
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9b64d1d48371ccea1c01630a33a245d90f45214
Gerrit-Change-Number: 41612
Gerrit-PatchSet: 10
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Ron Minnich
rminnich@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 May 2020 20:43:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment