Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47602
to look at the new patch set (#3).
Change subject: lib/version: Use .id section and remove id.S files ......................................................................
lib/version: Use .id section and remove id.S files
Selected strings from lib/version.c are moved from .rodata to .id.keep section. Pointers to such strings are added in .flashrom_id in structured form such that cbfstool can extract version information from the final ELF object.
For arch/arm[64], the offsets to board identification strings and CONFIG_ROM_SIZE inside .id were never really used; it was only a convenience to have the strings appear near the start of image. Order of strings is now undefined.
TBD: For arch/x86 util/cbfstool needs to post-process and invert the offsets in .flashrom_id section.
TBD: Check amd/picasso memlayout.
Change-Id: I35d3312336e9c66d657d2ca619cf30fd79e18fd4 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/arch/arm/Makefile.inc D src/arch/arm/id.S M src/arch/arm64/Makefile.inc D src/arch/arm64/id.S M src/arch/x86/Makefile.inc M src/arch/x86/bootblock.ld D src/arch/x86/id.S M src/lib/Makefile.inc A src/lib/flash_id.c M src/lib/program.ld M src/lib/version.c 11 files changed, 47 insertions(+), 86 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/47602/3