Kaiyen Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48302 )
Change subject: soc/intel/common/gpio_defs: Add a macro for EDGE_BOTH trigger pad ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48302/3/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/48302/3/src/soc/intel/common/block/... PS3, Line 276: ,
I think the actual problem here is that PAD_CFG_GPI_GPIO_DRIVER isn't configuring trigger as PAD_TRI […]
Thanks for your comment. I will try it. Your description for GPIO interrupts handling is correct, but I'm not sure if there are other GPIO settings rely on current setting (I mean didn't turn the TRIG off here) because maybe they (Depthcharge or Kernel) don't configure the interrupts correctly. I'm not sure if it will be better that we create another macro for GPI_GPIO setting with PAD_TRIG(OFF), instead of directly adding PAD_TRIG(OFF) here? What do you think?