Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35293 )
Change subject: Add ThinkPad R60 iGPU support.
......................................................................
Patch Set 31:
(3 comments)
Why can’t this be a variant?
https://review.coreboot.org/c/coreboot/+/35293/31//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35293/31//COMMIT_MSG@2
PS31, Line 2: Maccraft123
Please use your real name or a pseudonym.
https://review.coreboot.org/c/coreboot/+/35293/31//COMMIT_MSG@7
PS31, Line 7: Add ThinkPad R60 iGPU support.
No dot/period at the end of the commit message summary please, and please use a prefix. Maybe:
mb/lenovo: Add ThinkPad R60 iGPU support
https://review.coreboot.org/c/coreboot/+/35293/31//COMMIT_MSG@9
PS31, Line 9: It runs without any blobs in firmware
: Ethernet controller is detected by Linux
Please make this a list, and add a period/dot to the end of a sentence.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35293
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14ea3b91b5108652ce3f951bacea1c1f022da2b1
Gerrit-Change-Number: 35293
Gerrit-PatchSet: 31
Gerrit-Owner: Name of user not set #1002571
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Maccraft123
maccraft123mc@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Name of user not set #1002571
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Sep 2019 15:52:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment