Attention is currently required from: Mike Banon, Angel Pons. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38313 )
Change subject: [WIP] AGESA,binaryPI boards: Drop invalid MP table files ......................................................................
Patch Set 5:
(58 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/38313/comment/f263fab1_c710e274 PS5, Line 9: error
Could you please provide examples of errors in the dropped tables?
Done
File src/mainboard/amd/gardenia/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/a78c9042_e97536bd PS5, Line 99: /* PCI slots */ legacy pci?
https://review.coreboot.org/c/coreboot/+/38313/comment/4a149dd1_8d12f055 PS5, Line 122: /* PCIe Lan*/ Not even with sb800 / fam14 generation?
https://review.coreboot.org/c/coreboot/+/38313/comment/bbc3f12a_e1a26613 PS5, Line 125: /* FCH PCIe PortA */ No docs, but I suspect not at 0:15.0 listed below.
File src/mainboard/amd/olivehill/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/99c6467a_4c6ff35c PS5, Line 95: /* PCI slots */ ?
https://review.coreboot.org/c/coreboot/+/38313/comment/83ea2538_be80ee65 PS5, Line 118: /* PCIe Lan*/ ?
File src/mainboard/amd/parmer/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/fc979e02_6c9bd037 PS5, Line 116: /* PCIe Lan*/ ?
File src/mainboard/amd/persimmon/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/6ce5c512_9e3854b1 PS5, Line 81: /* IDE */ ?
https://review.coreboot.org/c/coreboot/+/38313/comment/e619d132_add8a9f0 PS5, Line 89: PCI_INT(0x2, 0x0, 0x0, intr_data_ptr[PIRQ_E]); /* Use INTE */ Should not use static number for PCI buses.
File src/mainboard/amd/thatcher/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/74a31ff4_5b487f29 PS5, Line 117: /* PCIe Lan*/ ?
File src/mainboard/asrock/e350m1/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/e0c1b974_9ff09e4f PS5, Line 68: /* PCI slots */ AFAIR, none
File src/mainboard/asrock/imb-a180/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/e986a92e_65b65bee PS5, Line 95: /* PCI slots */ none
https://review.coreboot.org/c/coreboot/+/38313/comment/5ca88202_96ef8dad PS5, Line 118: /* PCIe Lan*/ Bus 0, so would be internal LAN, not existing.
File src/mainboard/asus/am1i-a/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/7e8d2d61_1d463bf9 PS5, Line 90: PCI_INT(0x2, 0x0, 0x0, intr_data_ptr[PIRQ_B]); Using static numbers for PCI buses.
File src/mainboard/asus/f2a85-m/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/956b11ec_b3ff0122 PS5, Line 99: /* PCI slots */ From what I remember, there were 1-3 slots depending of board variant.
https://review.coreboot.org/c/coreboot/+/38313/comment/8026e971_6fa98b07 PS5, Line 110: /* PCIe Lan*/ Bus 0, internal non-existing
File src/mainboard/bap/ode_e20XX/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/cab7c4b5_a19b5ac6 PS5, Line 87: PCI_INT(0x2, 0x0, 0x0, intr_data_ptr[PIRQ_F]); Uses static number for PCI bus
https://review.coreboot.org/c/coreboot/+/38313/comment/0bd284d0_a16a1a98 PS5, Line 89: /* PCI slots */ I doubt it
https://review.coreboot.org/c/coreboot/+/38313/comment/290c71e5_afd45fd7 PS5, Line 116: /* PCIe Lan*/ Hmm... no?
File src/mainboard/biostar/a68n_5200/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/8f089a14_855835ed PS5, Line 95: /* PCI slots */ I doubt it
https://review.coreboot.org/c/coreboot/+/38313/comment/69a91872_7b8b1566 PS5, Line 118: /* PCIe Lan*/ No ?
File src/mainboard/biostar/am1ml/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/a6449b98_206f38db PS5, Line 68: PCI_INT(0x0, 0x14, 0x2, intr_data_ptr[PIRQ_HDA]); Duplicate 0:14.2 with OHCI4 ?
https://review.coreboot.org/c/coreboot/+/38313/comment/6c1269ef_e3fe4538 PS5, Line 80: PCI_INT(0x0, 0x14, 0x2, intr_data_ptr[PIRQ_OHCI4]); Duplicate 0:14.2 with HDA ?
https://review.coreboot.org/c/coreboot/+/38313/comment/86d6f5be_0e41057f PS5, Line 87: PCI_INT(0x2, 0x0, 0x0, intr_data_ptr[PIRQ_F]); Uses static PCI bus number
https://review.coreboot.org/c/coreboot/+/38313/comment/f73cfc80_a75f9f03 PS5, Line 89: /* PCI slots */ I doubt it
File src/mainboard/elmex/pcm205400/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/46ee5efa_32aeda21 PS5, Line 81: /* IDE */ I doubt it
https://review.coreboot.org/c/coreboot/+/38313/comment/051972d6_924db3bc PS5, Line 89: PCI_INT(0x2, 0x0, 0x0, intr_data_ptr[PIRQ_E]); /* Use INTE */ Use static PCI bus number
File src/mainboard/gizmosphere/gizmo/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/ad159d78_7905fb95 PS5, Line 68: /* PCI slots */ none
File src/mainboard/gizmosphere/gizmo2/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/e53cb2c0_3eda3fd6 PS5, Line 87: PCI_INT(0x2, 0x0, 0x0, intr_data_ptr[PIRQ_F]); static PCI bus number
https://review.coreboot.org/c/coreboot/+/38313/comment/a1e0a30b_6d2ff7dd PS5, Line 89: /* PCI slots */ none
https://review.coreboot.org/c/coreboot/+/38313/comment/585ea099_aaa29dcb PS5, Line 116: /* PCIe Lan*/ no internal
File src/mainboard/google/kahlee/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/86326b09_8e184ff9 PS5, Line 82: PCI_INT(0x0, 0x14, 0x0, intr_data_ptr[0x13]); Duplicate 0:14.0.
https://review.coreboot.org/c/coreboot/+/38313/comment/2dc49074_a7ece99f PS5, Line 95: PCI_INT(0x0, 0x11, 0x0, intr_data_ptr[0x41]); Duplicate 0:11.0?
https://review.coreboot.org/c/coreboot/+/38313/comment/8308fab7_66ddde30 PS5, Line 99: /* PCI slots */ none most likely
https://review.coreboot.org/c/coreboot/+/38313/comment/4f1f414c_917e6f78 PS5, Line 122: /* PCIe Lan*/ Internal, not since 2012?
File src/mainboard/hp/abm/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/b8751d5f_08527867 PS5, Line 78: PCI_INT(0x0, 0x14, 0x0, intr_data_ptr[0x13]); Duplicate 0:14.0
https://review.coreboot.org/c/coreboot/+/38313/comment/d3180838_ae685670 PS5, Line 91: PCI_INT(0x0, 0x11, 0x0, intr_data_ptr[0x41]); Duplicate 0:11.0
https://review.coreboot.org/c/coreboot/+/38313/comment/70dc013d_77357604 PS5, Line 95: /* PCI slots */ I doubt it
https://review.coreboot.org/c/coreboot/+/38313/comment/68d0b138_8b5b91ca PS5, Line 118: /* PCIe Lan*/ None
File src/mainboard/hp/pavilion_m6_1035dx/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/881e3230_4b5f44eb PS5, Line 82: PCI_INT(0x0, 0x14, 0x0, intr_data_ptr[0x13]); Duplicate 0:14.0
https://review.coreboot.org/c/coreboot/+/38313/comment/beed24c1_928c40b7 PS5, Line 95: PCI_INT(0x0, 0x11, 0x0, intr_data_ptr[0x41]); Duplicate 0:11.0
https://review.coreboot.org/c/coreboot/+/38313/comment/97261c86_8162cd98 PS5, Line 99: /* PCI slots */ Wow, laptop and 3 PCI legacy slots?
https://review.coreboot.org/c/coreboot/+/38313/comment/e3b926ef_bb0c1589 PS5, Line 122: /* PCIe Lan*/ no
File src/mainboard/jetway/nf81-t56n-lf/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/2e7f1fd5_e62982cd PS5, Line 81: /* IDE */ I doubt it
https://review.coreboot.org/c/coreboot/+/38313/comment/de761444_484b2cb2 PS5, Line 89: PCI_INT(0x2, 0x0, 0x0, intr_data_ptr[PIRQ_E]); /* Use INTE */ Static PCI numbers.
File src/mainboard/lenovo/g505s/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/b4522015_3ebe19b0 PS5, Line 82: PCI_INT(0x0, 0x14, 0x0, intr_data_ptr[0x13]); Duplicate 0:14.0
https://review.coreboot.org/c/coreboot/+/38313/comment/06f57d05_cc073f3b PS5, Line 95: PCI_INT(0x0, 0x11, 0x0, intr_data_ptr[0x41]); Duplicate 0:11.0
https://review.coreboot.org/c/coreboot/+/38313/comment/8f7dfff3_2824c501 PS5, Line 99: /* PCI slots */ none
https://review.coreboot.org/c/coreboot/+/38313/comment/ec3051ee_b9bba419 PS5, Line 122: /* PCIe Lan*/ Internal, none.
File src/mainboard/lippert/frontrunner-af/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/dd4abd54_06f716f2 PS5, Line 67: /* PCI slots */ Some of this might even be correct. It's PC104+ form factor so bit hard to tell or test.
File src/mainboard/msi/ms7721/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/1e43c114_67e09537 PS5, Line 82: PCI_INT(0x0, 0x14, 0x0, intr_data_ptr[0x13]); Duplicate 0:14.0
https://review.coreboot.org/c/coreboot/+/38313/comment/ec341c24_4cac4ac6 PS5, Line 95: PCI_INT(0x0, 0x11, 0x0, intr_data_ptr[0x41]); Duplicate 0:11.0
https://review.coreboot.org/c/coreboot/+/38313/comment/da3b6289_e504b4b9 PS5, Line 110: /* PCIe Lan*/ no
File src/mainboard/pcengines/apu1/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/47b523e5_3da8a7c9 PS5, Line 61: /* APU Internal Graphic Device */ No graphics
https://review.coreboot.org/c/coreboot/+/38313/comment/938a4c60_04fc7cf6 PS5, Line 68: /* Southbridge HD Audio */ Could be disabled, audio pins are not routed?
https://review.coreboot.org/c/coreboot/+/38313/comment/25c9e53d_f85f896a PS5, Line 81: /* IDE */ No
https://review.coreboot.org/c/coreboot/+/38313/comment/1a320e52_ee3fe298 PS5, Line 91: PCI_INT(0x4, 0x0, 0x0, intr_data_ptr[PIRQ_E]); /* Use INTE */ Static PCI bus numbers.
File src/mainboard/pcengines/apu2/mptable.c:
https://review.coreboot.org/c/coreboot/+/38313/comment/eb12c1fe_cad597e5 PS5, Line 80: PCI_INT(0x2, 0x0, 0x0, intr_data_ptr[PIRQ_F]); Static PCI bus numbers.