21 Apr
2020
21 Apr
'20
5:29 p.m.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39894 )
Change subject: tests: Add build subsystem for unit testing coreboot ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39894/2/tests/Makefile.inc File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39894/2/tests/Makefile.inc@128 PS2, Line 128: cp $(DEFAULT_CONFIG) $(TEST_DOTCONFIG) I cherry-picked the set of changes to my local tree, followed the instructions in the next CL, and got this error: cp: missing destination file operand after 'tests/.config' I think you may need $(TEST_DEFAULT_CONFIG) here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/39894
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b0220b84b9a6e448476ca3eb3ccccc5fb829ad1
Gerrit-Change-Number: 39894
Gerrit-PatchSet: 2
Gerrit-Owner: Name of user not set #1002873
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Paul Fagerburg pfagerburg@chromium.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 21 Apr 2020 15:29:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment