Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39882 )
Change subject: fsp2_0: Clean up around `config FSP_USE_REPO`
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39882/2/src/drivers/intel/fsp2_0/Kc...
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/39882/2/src/drivers/intel/fsp2_0/Kc...
PS2, Line 34: FSP_USE_REPO
: bool "Use binaries of the Intel FSP repository on GitHub"
: depends on HAVE_INTEL_FSP_REPO
: default y
only place these defaults don't seem to work properly is for GeminiLake, since it inherits from Apollolake but can't use the APL FSP repo
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39882
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8538f2e966adc9da0fbea2250c954d86e42dfeb3
Gerrit-Change-Number: 39882
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 03 Apr 2020 19:08:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment