Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31423 )
Change subject: SMBIOS: Add new MEMORY_{TYPE,TECHNOLOGY,OPERATING} macros ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/31423/2/src/include/smbios.h File src/include/smbios.h:
https://review.coreboot.org/#/c/31423/2/src/include/smbios.h@94 PS2, Line 94: MEMORY Why double memory? You start with the word memory, you don't need to finish with the word memory too(other defined fields don't have it).
https://review.coreboot.org/#/c/31423/2/src/include/smbios.h@97 PS2, Line 97: MODE_CAP MODE_CAP? Why not simply MODE? Or are you indicating it's a capability, and that more then 1 bit can be set at the same time?