31 Jan
2020
31 Jan
'20
9:36 p.m.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 )
Change subject: mb/apple: Add MacBook Pro 8,1 support ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33151/10/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/33151/10/src/mainboard/apple/macboo... PS10, Line 26: AZALIA_SUBVENDOR(0, 0x106b1c00), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/33151/10/src/mainboard/apple/macboo... PS10, Line 38: 0x80862805, /* Codec Vendor / Device ID: Intel */ please, no spaces at the start of a line
--
To view, visit https://review.coreboot.org/c/coreboot/+/33151
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2
Gerrit-Change-Number: 33151
Gerrit-PatchSet: 10
Gerrit-Owner: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 31 Jan 2020 21:36:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment