CK HU has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44410 )
Change subject: soc/mediatek/mt8192: Add DRAM resource in ramstage
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44410/2/src/soc/mediatek/mt8192/soc...
File src/soc/mediatek/mt8192/soc.c:
https://review.coreboot.org/c/coreboot/+/44410/2/src/soc/mediatek/mt8192/soc...
PS2, Line 5: #include <symbols.h>
is this used ?
It's redundant. But this patch has been merged, so I would send another patch to remove this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44410
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac02f81fc7d47851b3bba442eb7043169fbdbcfb
Gerrit-Change-Number: 44410
Gerrit-PatchSet: 2
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 14 Aug 2020 01:48:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment