Attention is currently required from: Bao Zheng, Zheng Bao.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69856 )
Change subject: WIP:amdfwtool: Allow the location to be a relative address ......................................................................
Patch Set 4:
(6 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167591): https://review.coreboot.org/c/coreboot/+/69856/comment/41cf9aba_bc5cfa6f PS4, Line 2475: case 0xFA0000: /* Fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167591): https://review.coreboot.org/c/coreboot/+/69856/comment/c2f200e3_dd81cafd PS4, Line 2476: case 0xF20000: /* Fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167591): https://review.coreboot.org/c/coreboot/+/69856/comment/d077c7c4_2de2e3f1 PS4, Line 2477: case 0xE20000: /* Fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167591): https://review.coreboot.org/c/coreboot/+/69856/comment/9c34faae_a1a9bc01 PS4, Line 2478: case 0xC20000: /* Fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167591): https://review.coreboot.org/c/coreboot/+/69856/comment/96196375_d63d1240 PS4, Line 2479: case 0x820000: /* Fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167591): https://review.coreboot.org/c/coreboot/+/69856/comment/aa81abf3_af78b78d PS4, Line 2480: case 0x020000: /* Fallthrough */ Prefer 'fallthrough;' over fallthrough comment