Attention is currently required from: Raul Rangel, Nico Huber, Patrick Georgi, Kyösti Mälkki.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61306 )
Change subject: console: Add loglevel prefix to interactive consoles
......................................................................
Patch Set 4:
(1 comment)
File src/console/console.c:
https://review.coreboot.org/c/coreboot/+/61306/comment/8a1dd85b_7d489f38
PS3, Line 27: line_start
You would need to expose `prefix_tx_byte`, or probably better renamed to `interactive_console_tx_byt […]
Hmmm... yeah, actually, on second thought I see your point, that does work out pretty nicely! And I didn't actually notice before that my previous implementation didn't work with the CONSOLE_LOG_FAST thing at all, which I fixed now too. I even managed to avoid the global variable entirely, PTAL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61306
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic83413475400821f8097ef1819a293ee8926bb0b
Gerrit-Change-Number: 61306
Gerrit-PatchSet: 4
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 03 Feb 2022 02:03:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment