Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45138 )
Change subject: arch/x86/smbios: Update SMBIOS type 0 ec version ......................................................................
Patch Set 8: Code-Review+1
(3 comments)
If Patrick +2'd this, I imagine this is good. I was concerned with BMC != EC, but I guess it's close enough.
https://review.coreboot.org/c/coreboot/+/45138/2/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/45138/2/src/arch/x86/smbios.c@428 PS2, Line 428: smbios_ec_revision(&ipmi_bmc_major_revision, &ipmi_bmc_minor_revision); : t->ec_major_release = ipmi_bmc_major_revision; : t->ec_minor_release = ipmi_bmc_minor_revision;
Because there's no EC in deltalake, we use BMC to represent EC.
Ack
https://review.coreboot.org/c/coreboot/+/45138/2/src/drivers/ipmi/ipmi_kcs_o... File src/drivers/ipmi/ipmi_kcs_ops.c:
https://review.coreboot.org/c/coreboot/+/45138/2/src/drivers/ipmi/ipmi_kcs_o... PS2, Line 283: ((bmc_revision_major / 16) * 10) + (bmc_revision_major % 16)
In ipmi spec, Firmware Revision was defined into BCD encoded. […]
Ack
https://review.coreboot.org/c/coreboot/+/45138/5/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/45138/5/src/mainboard/ocp/deltalake... PS5, Line 38: *ec_major_revision = bmc_major_revision; : *ec_minor_revision = ((bmc_minor_revision / 16) * 10) + (bmc_minor_revision % 16);
After checked with YV3 team, I found that the format of Firmware Revision 1 and Firmware Revision 2 […]
Ack