If Patrick +2'd this, I imagine this is good. I was concerned with BMC != EC, but I guess it's close enough.
Patch set 8:Code-Review +1
3 comments:
smbios_ec_revision(&ipmi_bmc_major_revision, &ipmi_bmc_minor_revision);
t->ec_major_release = ipmi_bmc_major_revision;
t->ec_minor_release = ipmi_bmc_minor_revision;
Because there's no EC in deltalake, we use BMC to represent EC.
Ack
File src/drivers/ipmi/ipmi_kcs_ops.c:
Patch Set #2, Line 283: ((bmc_revision_major / 16) * 10) + (bmc_revision_major % 16)
In ipmi spec, Firmware Revision was defined into BCD encoded. […]
Ack
File src/mainboard/ocp/deltalake/ramstage.c:
*ec_major_revision = bmc_major_revision;
*ec_minor_revision = ((bmc_minor_revision / 16) * 10) + (bmc_minor_revision % 16);
After checked with YV3 team, I found that the format of Firmware Revision 1 and Firmware Revision 2 […]
Ack
To view, visit change 45138. To unsubscribe, or for help writing mail filters, visit settings.