Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44431 )
Change subject: mb/tigerlake: Disable Precision Time Measurement for PCIe RP 9
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44431/5/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/44431/5/src/soc/intel/tigerlake/fsp...
PS5, Line 188: PciePtm
Since this UPD is set to 1 by default and devicetree options are 0 by default this change will end up disabling PTM for all ports unless it is explicitly enabled in the devicetree. I assume that is not what was intended so I inverted the option to allow only disabling for particular ports: https://review.coreboot.org/c/coreboot/+/46856
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44431
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72126c2013c4ddac2884b7d40ef043e80d432331
Gerrit-Change-Number: 44431
Gerrit-PatchSet: 5
Gerrit-Owner: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.corp-partner.google.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 28 Oct 2020 01:11:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment