Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42193 )
Change subject: soc/mediatek/mt8183: Fix some programming errors of DRAMC setting ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42193/2/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/42193/2/src/soc/mediatek/mt8183/dra... PS2, Line 894: (0x3 << 4) | (0x1 << 7) | (0x1 << 13), Move to next line.
https://review.coreboot.org/c/coreboot/+/42193/2/src/soc/mediatek/mt8183/dra... PS2, Line 952: (0x3 << 4) | (0x1 << 7) | (0x1 << 13), Move to next line.
https://review.coreboot.org/c/coreboot/+/42193/2/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/42193/2/src/soc/mediatek/mt8183/dra... PS2, Line 51: size_t u8