Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37911 )
Change subject: mb/google/kohaku: Set reset hold time for I2C digitizer device
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37911/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37911/1/src/mainboard/google/hatch/...
PS1, Line 213: post-power-on-delay-ms
Just curious: Is this better/different than setting "reset_delay_ms" to 100 above in line 209 above?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37911
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccb33c13c9a390a2c971325c74c0c4ad4b08618e
Gerrit-Change-Number: 37911
Gerrit-PatchSet: 1
Gerrit-Owner: Seunghwan Kim
sh_.kim@samsung.com
Gerrit-Reviewer: Seunghwan Kim
sh_.kim@samsung.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Mon, 23 Dec 2019 10:10:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment