Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49231 )
Change subject: util/autoport: Rename to mainboard_fill_gnvs() ......................................................................
util/autoport: Rename to mainboard_fill_gnvs()
Change-Id: Ia8d7083ca2f21abbb5f184c1b55dcf1bf047a7be Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49231 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M util/autoport/bd82x6x.go M util/autoport/readme.md 2 files changed, 4 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/util/autoport/bd82x6x.go b/util/autoport/bd82x6x.go index 5d943e4..e2a84e4 100644 --- a/util/autoport/bd82x6x.go +++ b/util/autoport/bd82x6x.go @@ -359,10 +359,11 @@ defer gnvs.Close()
Add_gpl(gnvs) - gnvs.WriteString(`#include <southbridge/intel/bd82x6x/nvs.h> + gnvs.WriteString(`#include <acpi/acpi_gnvs.h> +#include <southbridge/intel/bd82x6x/nvs.h>
/* FIXME: check this function. */ -void acpi_create_gnvs(struct global_nvs *gnvs) +void mainboard_fill_gnvs(struct global_nvs *gnvs) { /* The lid is open by default. */ gnvs->lids = 1; diff --git a/util/autoport/readme.md b/util/autoport/readme.md index bfaaef6..f2b2697 100644 --- a/util/autoport/readme.md +++ b/util/autoport/readme.md @@ -335,7 +335,7 @@
## GNVS
-`acpi_create_gnvs` sets values in GNVS, which then ACPI makes use of for +`mainboard_fill_gnvs` sets values in GNVS, which then ACPI makes use of for various power-related functions. Normally, there is no need to modify it on laptops (desktops have no "lid"!) but it makes sense to proofread it.