Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31416 )
Change subject: SMBIOS: Update BIOS Information (Type 0) to version V3.2.0 ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/31416/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31416/2//COMMIT_MSG@10 PS2, Line 10: Also fix some coding style
This seems completely unrelated, please split out.
Agree
https://review.coreboot.org/#/c/31416/2/src/include/smbios.h File src/include/smbios.h:
https://review.coreboot.org/#/c/31416/2/src/include/smbios.h@55 PS2, Line 55: #define BIOS_CHARACTERISTICS_PCI_SUPPORTED (1 << 7) : #define BIOS_CHARACTERISTICS_PC_CARD (1 << 8) : #define BIOS_CHARACTERISTICS_PNP (1 << 9) : #define BIOS_CHARACTERISTICS_APM (1 << 10) : #define BIOS_CHARACTERISTICS_UPGRADEABLE (1 << 11) : #define BIOS_CHARACTERISTICS_SHADOW (1 << 12) : #define BIOS_CHARACTERISTICS_BOOT_FROM_CD (1 << 15) : #define BIOS_CHARACTERISTICS_SELECTABLE_BOOT (1 << 16) : #define BIOS_CHARACTERISTICS_BIOS_SOCKETED (1 << 17) : : #define BIOS_EXT1_CHARACTERISTICS_ACPI (1 << 0) : #define BIOS_EXT2_CHARACTERISTICS_TARGET (1 << 2) : This does not belong to updating SMBIOS, should be on a separate patch. You might look for other files (usually header files) needing alignment... though I would not call it fixing code style. Just say "align values for readability".
https://review.coreboot.org/#/c/31416/2/src/include/smbios.h@238 PS2, Line 238: u16 extended_bios_rom_size; While this does belong to SMBIOS update.