Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46373 )
Change subject: haswell/broadwell: Fix `BLCK` typo ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46373/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46373/2//COMMIT_MSG@7 PS2, Line 7: BLCK Probably better to use the correct spelling here.
https://review.coreboot.org/c/coreboot/+/46373/2/src/cpu/intel/haswell/haswe... File src/cpu/intel/haswell/haswell_init.c:
https://review.coreboot.org/c/coreboot/+/46373/2/src/cpu/intel/haswell/haswe... PS2, Line 211: * the 100MHz BCLCK against the 24MHz BCLK to restore the clocks properly Ugh, sorry, I thought this would be a quick review. But I don't understand the sentence at all and can't say if BCLK is meant here. I'll try to find something about this in the docs. 24MHz sounds like the usual external crystal btw.