Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48236 )
Change subject: mb/emulation/qemu-q35: Account for TSEG ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48236/7/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-q35/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48236/7/src/mainboard/emulation/qem... PS7, Line 10: postcar-y += memmap.c Are this and the later entries needed? I thought since we pass the top pointer from stage to stage now, we only call cbmem_top_chipset() in romstage. Or is this just in preparation?
https://review.coreboot.org/c/coreboot/+/48236/7/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-q35/memmap.c:
https://review.coreboot.org/c/coreboot/+/48236/7/src/mainboard/emulation/qem... PS7, Line 42: ld %zu