Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu, Jianjun Wang. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56792 )
Change subject: soc/mediatek/mt8195: Add driver to configure PCIe ......................................................................
Patch Set 19: Code-Review+1
(1 comment)
File src/soc/mediatek/mt8195/pcie.c:
https://review.coreboot.org/c/coreboot/+/56792/comment/19162497_d341a67f PS19, Line 23: /* MMIO range (64MB): 0x20000000 ~ 0x24000000 */ : /* Some devices still need io ranges, reserve 16MB for compatibility */ : static struct mtk_pcie_mmio_res pcie_mmio_res_io = { : .cpu_addr = 0x20000000, : .pci_addr = 0x20000000, : .size = 16 * MiB, : .type = IORESOURCE_IO, : }; : : static struct mtk_pcie_mmio_res pcie_mmio_res_mem = { : .cpu_addr = 0x21000000, : .pci_addr = 0x21000000, : .size = 48 * MiB, : .type = IORESOURCE_MEM, : }; These can be const, but CB:56791 needs to be updated to avoid compile-time errors about dropping "const" qualifier.