Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39919 )
Change subject: mb/google/slippy: Convert variants to use override devicetree ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39919/1/src/mainboard/google/slippy... File src/mainboard/google/slippy/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39919/1/src/mainboard/google/slippy... PS1, Line 17: # Enable Panel and configure power delays : register "gpu_panel_port_select" = "1" # eDP : register "gpu_panel_power_cycle_delay" = "5" # 400ms (T4) : register "gpu_panel_power_up_delay" = "600" # 60ms (T1+T2) : register "gpu_panel_power_down_delay" = "600" # 60ms (T3+T7) : register "gpu_panel_power_backlight_on_delay" = "2100" # 210ms (T5) : register "gpu_panel_power_backlight_off_delay" = "2100" # 210ms (T6)
Drop this, and let each variant specify the values?
done. swore I did, must have snuck back in
https://review.coreboot.org/c/coreboot/+/39919/1/src/mainboard/google/slippy... File src/mainboard/google/slippy/variants/falco/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39919/1/src/mainboard/google/slippy... PS1, Line 4: register "gpu_panel_port_select" = "1" # eDP
This is common for all four boards
cleaner just to keep the entire panel section together IMO
https://review.coreboot.org/c/coreboot/+/39919/1/src/mainboard/google/slippy... PS1, Line 17:
blank line
Done
https://review.coreboot.org/c/coreboot/+/39919/1/src/mainboard/google/slippy... File src/mainboard/google/slippy/variants/leon/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39919/1/src/mainboard/google/slippy... PS1, Line 52:
Blank line
Done
https://review.coreboot.org/c/coreboot/+/39919/1/src/mainboard/google/slippy... File src/mainboard/google/slippy/variants/peppy/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39919/1/src/mainboard/google/slippy... PS1, Line 21:
blank line
Done