[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Enable ACPI timer emulation if PM timer is disa...

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34563 )

Change subject: soc/intel/cannonlake: Enable ACPI timer emulation if PM timer is disabled
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34563/1/src/soc/intel/cannonlake/cp... 
File src/soc/intel/cannonlake/cpu.c:

https://review.coreboot.org/c/coreboot/+/34563/1/src/soc/intel/cannonlake/cp... 
PS1, Line 387: config_t
> Used it to be consistent with similar usage in the file.

yeah, i got it, but lately i got a feedback from some reviewer that Cb practice would be avoid typedef as much as we can.

if you see we have mixed approach in some patches where we are using struct soc_intel_cannonlake_config *config and in some cases we are using config_t :)