Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35204 )
Change subject: [TEST-ONLY] Distinguish SKU1 and 2 for eMMC and SSD respectively
......................................................................
Patch Set 4:
Patch Set 4:
Whether eMMC or SSD in M/B will be locked down during SMT by BOM therefore could we take care of that for non-mounting one (either eMMC or SSD) we can fine-tune pins for N/C, PU or PD to avoid any leakage or interrupt storm? As a result, at least we can support 255?
Dear Marco, sorry feedback to you later. I confirmed with our factory team and PM, Proto board just power on, BTW don't do factory flow. So I think SKU255 for Proto build that is fine.
1. Even for proto stage, the SKU ID 255 still needs to be ensure that board can be power on generally; otherwise everyone got this board needs to re-program SKU ID by servo console?
2. Considering to EVT, we still need to evaluate to boot up by 255.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35204
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I827e6f1420801d43e0eb4708b8b8ad1692ef7e9f
Gerrit-Change-Number: 35204
Gerrit-PatchSet: 4
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Guohui Zhou
guohui.zhou@bitland.corp-partner.google.com
Gerrit-CC: Marco Chen
marcochen@google.com
Gerrit-Comment-Date: Thu, 05 Sep 2019 07:31:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment