[coreboot-gerrit] Change in coreboot[master]: drivers/uart: Override uart base address

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45405 )

Change subject: drivers/uart: Override uart base address
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45405/2/src/drivers/uart/uart8250io... 
File src/drivers/uart/uart8250io.c:

https://review.coreboot.org/c/coreboot/+/45405/2/src/drivers/uart/uart8250io... 
PS2, Line 78: static const unsigned int bases[] = { 0x3f8, 0x2f8, 0x3e8, 0x2e8 };
> Marc, For DeltaLake, we are in the process of polishing the firmware image for it to be used by othe […]

So why not use a cmos option and the get_option function?  Look at how init_log_level in console/init.c works.  You can set a bitfield for the typical values or if you wanted to allow any value, you can use an int.