Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42899 )
Change subject: sc7180: Add support for sn65dsi86 bridge. ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42899/7/src/drivers/ti/sn65dsi86bri... File src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c:
https://review.coreboot.org/c/coreboot/+/42899/7/src/drivers/ti/sn65dsi86bri... PS7, Line 470: data As discussed over email, this needs to be masked with a DP_LANE_COUNT_MASK (0xf).
https://review.coreboot.org/c/coreboot/+/42899/7/src/drivers/ti/sn65dsi86bri... PS7, Line 484: i2c_write_field(bus, chip, SN_DPPLL_SRC_REG, ref_clk, 7, 1); As discussed over email, this (and probably HPD) should be factored out into a separate function that has to be called before reading the EDID.