Balázs Vinarz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: Add Asus A88XM-E FM2+ motherboard with documentation, the port based on F2A85-M. ......................................................................
Patch Set 3:
(9 comments)
Patch Set 3:
Hi there Balázs! Please could you tell more about your hardware setup, especially what CPU you are using with your A88XM-E board? Thank you in advance
It's an A8-6500.
https://review.coreboot.org/#/c/30987/2/Documentation/mainboard/asus/a88xm-e... File Documentation/mainboard/asus/a88xm-e.md:
https://review.coreboot.org/#/c/30987/2/Documentation/mainboard/asus/a88xm-e... PS2, Line 13: and their GPU is [Sea Islands] (GCN2-based).
We have binaryPI blob for Kaveri, but it is for FP3 socket only. […]
Ack
https://review.coreboot.org/#/c/30987/2/Documentation/mainboard/asus/a88xm-e... PS2, Line 59:
trailing space
Ack
https://review.coreboot.org/#/c/30987/2/Documentation/mainboard/asus/a88xm-e... PS2, Line 83: - Integrated ethernet
Maybe it is missing a MAC address? coreboot has a driver for that.
It's not. No interface/device found on OS level, neighter during Coreboot init. But the device tree has been modified according to the factory bios.
https://review.coreboot.org/#/c/30987/2/Documentation/mainboard/asus/a88xm-e... PS2, Line 87:
trailing space
Ack
https://review.coreboot.org/#/c/30987/2/Documentation/mainboard/asus/a88xm-e... PS2, Line 88: board with factory image makes it work again as fallback.
I think xhci firmware loader in fam15tn vendorcode was buggy. […]
Angel: Belive me, I tried literally everything. Somehow I managed it to work once on F2A85-M, but never again. After starting with wrong blob, just another power off and boot with factory image managed it to work again.
Kyösti: the firmware is very similar for both chipsets, but it differs of course.
For both of you: Can we go with extracted blobs (microcode, psp, vga, xhci...)? Are these allowed to ship with the coreboot sources or are these marked as leaked ones?
https://review.coreboot.org/#/c/30987/2/src/mainboard/asus/a88xm-e/Kconfig File src/mainboard/asus/a88xm-e/Kconfig:
https://review.coreboot.org/#/c/30987/2/src/mainboard/asus/a88xm-e/Kconfig@2... PS2, Line 29: SUPERIO_ITE_IT8728F
This works with the ITE IT8603?
Yes, it is. Probably really same chip, just different package pin count. https://lm-sensors.lm-sensors.narkive.com/VnxI9zvt/it8620e-it8623e-vs-it8603...
https://review.coreboot.org/#/c/30987/2/src/mainboard/asus/a88xm-e/Kconfig@1... PS2, Line 113: config DEVICETREE : string : default "devicetree_a88xm-e.cb"
Rename the devicetree to "devicetree.cb" and drop this.
Done
https://review.coreboot.org/#/c/30987/2/src/mainboard/asus/a88xm-e/board_inf... File src/mainboard/asus/a88xm-e/board_info.txt:
https://review.coreboot.org/#/c/30987/2/src/mainboard/asus/a88xm-e/board_inf... PS2, Line 4: [http://www.winbond.com/hq/product/code-storage-flash-memory/serial-nor-flash... SPI]
There is no need to link anything here. Just "SPI" is enough.
Done
https://review.coreboot.org/#/c/30987/2/src/mainboard/asus/a88xm-e/romstage.... File src/mainboard/asus/a88xm-e/romstage.c:
https://review.coreboot.org/#/c/30987/2/src/mainboard/asus/a88xm-e/romstage.... PS2, Line 49: pnp_devfn_t uart = PNP_DEV(0x2e, IT8728F_SP1); : pnp_devfn_t gpio = PNP_DEV(0x2e, IT8728F_GPIO);
These can be macros
I wouldn't bother these lines, the GPIO have a 0x07 value on superio/ite/it8728f/it8728f.h.