Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37738 )
Change subject: src/mainboard: remove MMIO macros
......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37738/16/src/mainboard/amd/thatcher...
File src/mainboard/amd/thatcher/romstage.c:
https://review.coreboot.org/c/coreboot/+/37738/16/src/mainboard/amd/thatcher...
PS16, Line 54: gpio_100_write8(0x101, 0x98);
Oops, that should have been 0x1, not 0x101. This is the last patch set, I promise.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37738
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I583034ef0b0ed3e5a5e3dd680c57728ec5efbc8f
Gerrit-Change-Number: 37738
Gerrit-PatchSet: 17
Gerrit-Owner: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Rudolf Marek
r.marek@assembler.cz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 05 Jan 2020 01:41:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Idwer Vollering
vidwer@gmail.com
Gerrit-MessageType: comment