Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48162 )
Change subject: lenovo/g505s: update the ACPI routing to match the new IRQ routing ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/48162/1/src/mainboard/lenovo/g505s/... File src/mainboard/lenovo/g505s/acpi/routing.asl:
https://review.coreboot.org/c/coreboot/+/48162/1/src/mainboard/lenovo/g505s/... PS1, Line 13: IRQ 3 These things are whatever is programmed in INTx# so it's not very useful information.
https://review.coreboot.org/c/coreboot/+/48162/1/src/mainboard/lenovo/g505s/... PS1, Line 54: Bus 0, Dev 20 Put this in order?
https://review.coreboot.org/c/coreboot/+/48162/1/src/mainboard/lenovo/g505s/... PS1, Line 66: IRQ 3 This routing table uses APIC interrupts not legacy PIC interrupts so this comment is wrong. You can see that IRQ 16-19 is used this PCI device, not 3
https://review.coreboot.org/c/coreboot/+/48162/1/src/mainboard/lenovo/g505s/... PS1, Line 123: 1:00.00 This is dynamically allocated so please remove.