Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67944 )
Change subject: mb/google/nissa/var/xivu: Add DPTF parameters for Xivu
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
@Ian Feng, what's the reason to keep pl1_min and pl1_max both values to the same 6W ?
Under Passive policy for any of the sensor's defined temperature trip point reach, in that case there won't be any pl1 power throttling happen, if both pl1_min and Pl1_max values are the same.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67944
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7e0c73815dd02b97d89f94fab09a241b6279830
Gerrit-Change-Number: 67944
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 03 Oct 2022 10:23:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment