Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33620 )
Change subject: soc/amd: Update ACPI code
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33620/1/src/soc/amd/common/acpi/lpc.asl
File src/soc/amd/common/acpi/lpc.asl:
https://review.coreboot.org/#/c/33620/1/src/soc/amd/common/acpi/lpc.asl@a41
PS1, Line 41:
:
Using value other than 0, since the base and length will be updated anyway, but I remember that stay […]
Thanks, I'll check if this solves this particular problem.
https://review.coreboot.org/#/c/33620/1/src/soc/amd/common/acpi/lpc.asl@35
PS1, Line 35: WIN77
WIN7
My keyboard sometimes double type the 7. Thanks for catching.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33620
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3615a4460dd4e0c95e890a38210263dd8ea6887
Gerrit-Change-Number: 33620
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Charles Marslett
charles.marslett@silverbackltd.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Lance Zhao
lance.zhao@gmail.com
Gerrit-Comment-Date: Thu, 20 Jun 2019 15:10:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Lance Zhao
lance.zhao@gmail.com
Gerrit-MessageType: comment