Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86105?usp=email )
Change subject: Revert "UPSTREAM: soc/intel/pantherlake: Update PlatformDebugOption to Trace Ready" ......................................................................
Revert "UPSTREAM: soc/intel/pantherlake: Update PlatformDebugOption to Trace Ready"
This default configuration caused a problem where USB devices connected behind a powered hub and/or Servo v4.1 were not detected.
Reverting this change restores the previous behavior where Trace Hub and DCI are disabled by default, resolving the USB detection issue.
BUG=b:384453901 TEST=Able to boot google/fatcat using USB storage behind servo v4.1
This reverts commit 1ed186fbff84386e0196dd30dd7bc89b8fec2cec.
Change-Id: I1a0f66d7ddf84622820f82c559d7d6b846ba3a7d Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/86105 Reviewed-by: Jamie Ryu jamie.m.ryu@intel.com Reviewed-by: Jérémy Compostella jeremy.compostella@intel.com Reviewed-by: Bora Guvendik bora.guvendik@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Pranava Y N pranavayn@google.com Reviewed-by: Gaggery Tsai gaggery.tsai@intel.com --- M src/soc/intel/pantherlake/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: Bora Guvendik: Looks good to me, but someone else must approve build bot (Jenkins): Verified Jérémy Compostella: Looks good to me, approved Pranava Y N: Looks good to me, approved Jamie Ryu: Looks good to me, approved Gaggery Tsai: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/pantherlake/Kconfig b/src/soc/intel/pantherlake/Kconfig index 4f6f658..dde401b 100644 --- a/src/soc/intel/pantherlake/Kconfig +++ b/src/soc/intel/pantherlake/Kconfig @@ -95,7 +95,6 @@ select SOC_INTEL_CSE_LITE_PSR if MAINBOARD_HAS_CHROMEOS && SOC_INTEL_CSE_LITE_SKU select SOC_INTEL_CSE_SEND_EOP_LATE if !MAINBOARD_HAS_CHROMEOS select SOC_INTEL_CSE_SET_EOP - select SOC_INTEL_DEBUG_CONSENT # TODO: Remove the safe setting for ES SoC select SOC_INTEL_GFX_NON_PREFETCHABLE_MMIO select SOC_INTEL_IOE_DIE_SUPPORT select SOC_INTEL_MEM_MAPPED_PM_CONFIGURATION