[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/pch: Enable PCH Thermal Sensor for threshold configu...

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33129 )

Change subject: soc/intel/common/pch: Enable PCH Thermal Sensor for threshold configuration
......................................................................

Patch Set 12:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33129/12/src/soc/intel/common/pch/t... 
File src/soc/intel/common/pch/thermal/thermal.c:

PS12:
> thats the correct expectation Furquan but we were also assessing how do we make more common code bas […]

I don't completely agree that adding this IP to common/block would be a maintenance issue. It keeps all IPs together. Again, you can always select SOC_INTEL_COMMON_BLOCK_THERMAL in pch/Kconfig like you have been doing for all the other IPs in there.

In my opinion, splitting IPs to be under common/block and common/pch would end up creating more confusion.