27 May
2020
27 May
'20
2:03 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41785 )
Change subject: cpu/x86/mtrr.h: Get rid of commonlib/helpers.h dependency ......................................................................
Patch Set 2:
How about just getting rid of ALIGN() from commonlib/helpers.h? I think people shouldn't use that anyway, they should use ALIGN_UP() for clarity. That way we aren't just kicking this can down the road until the next header runs into this problem.
--
To view, visit https://review.coreboot.org/c/coreboot/+/41785
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bf20733418ca4135f364a3f6489e74d45e4f466
Gerrit-Change-Number: 41785
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Aaron Durbin adurbin@chromium.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Wed, 27 May 2020 20:03:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment