Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )
Change subject: trogdor: Latch GPIO interrupt support ......................................................................
Patch Set 9:
(6 comments)
https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/board.h:
https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... PS5, Line 29: GPIO_PULLNONE = 0,
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... PS5, Line 29: GPIO_PULLNONE = 0,
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... PS5, Line 30: GPIO_PULLUP = 1,
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... PS5, Line 30: GPIO_PULLUP = 1,
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... PS5, Line 31: GPIO_PULLDOWN = 2,
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... PS5, Line 31: GPIO_PULLDOWN = 2,
code indent should use tabs where possible
Done