Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation ......................................................................
Patch Set 35:
(3 comments)
I have restored IOMMU since it's working, and done the other requested changes.
https://review.coreboot.org/c/coreboot/+/30987/31/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/Kconfig:
https://review.coreboot.org/c/coreboot/+/30987/31/src/mainboard/asus/a88xm-e... PS31, Line 93: config CONFIG_DRIVERS_PS2_KEYBOARD : bool : default y
Even then, SeaBIOS has drivers to initialize the keyboard, so I would not set this here.
Done.
https://review.coreboot.org/c/coreboot/+/30987/31/src/mainboard/asus/a88xm-e... PS31, Line 105: config POST_IO : bool : default n : : config CONFIG_POST_DEVICE_PCI_PCIE : bool : default y
Which PCI debugger model you are using, by the way?
Done (these options could be set locally if needed).
https://review.coreboot.org/c/coreboot/+/30987/31/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/cmos.layout:
https://review.coreboot.org/c/coreboot/+/30987/31/src/mainboard/asus/a88xm-e... PS31, Line 32: 456 1 e 1 ECC_memory
I think you can comment it out (add a # at the beginning) so as to keep things aligned with other bo […]
Done.