Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47051 )
Change subject: mb/purism/librem_cnl: Adjust in preparation for new variants ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem... PS1, Line 4: select SOC_INTEL_WHISKEYLAKE
It doesn't look like a rule, yeah but it still makes it pretty clear how that choice/names mechanism […]
The Kconfig.name thing is a bit of a hack to work around deficiencies in the Kconfig language. While it would be nice to keep options close to the board's definition, I also agree that we should limit Kconfig.name's scope to filling in board names in the choice.