build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32290 )
Change subject: Klocwork: Fix the Null pointer derefernce found by klocwork
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/32290/4/src/lib/string.c
File src/lib/string.c:
https://review.coreboot.org/#/c/32290/4/src/lib/string.c@9
PS4, Line 9: if (d) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/32290/4/util/cbfstool/cbfs_sections.c
File util/cbfstool/cbfs_sections.c:
https://review.coreboot.org/#/c/32290/4/util/cbfstool/cbfs_sections.c@69
PS4, Line 69: printf("Error, list_node pointer checked for NULL failed! \n");
unnecessary whitespace before a quoted newline
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32290
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15973ac28e9645826986cf63d2160eedb83024e4
Gerrit-Change-Number: 32290
Gerrit-PatchSet: 4
Gerrit-Owner: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Comment-Date: Fri, 12 Apr 2019 20:05:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment