Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu, Yidi Lin.
Liju-Clr Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69088 )
Change subject: soc/mediatek/mt8188: Allow MCUPM to access the secure registers
......................................................................
Patch Set 1:
(1 comment)
File src/soc/mediatek/mt8188/devapc.c:
https://review.coreboot.org/c/coreboot/+/69088/comment/f860bba5_c5faae10
PS1, Line 1557: SCP_SSPM_DOM, DOMAIN_2
don't we need to keep SCP/SSPM in domain2? […]
For MT8188, DEVAPC configures the hardwares(AP/others) as domain 0 by default and enables no_protection permssions for domain 0. The other domains are forbidden to access the registers.
Later, we will investigate the requirements from the module owners to configure the different domains and enable the access permissions for the different hardwares.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69088
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67b08c38a31a7eae1bc59543a5148a78b61456d6
Gerrit-Change-Number: 69088
Gerrit-PatchSet: 1
Gerrit-Owner: Liju-Clr Chen
liju-clr.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Tue, 01 Nov 2022 07:40:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment