Attention is currently required from: Maulik V Vaghela, Paul Menzel, Meera Ravindranath, Subrata Banik, Patrick Rudolph. Sathya Prakash M R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51408 )
Change subject: src/arch/smbios.c: Allow mainboard to fill Vendor name ......................................................................
Patch Set 6:
(1 comment)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/51408/comment/abb83cf5_00540423 PS6, Line 390: CONFIG_MAINBOARD_VENDOR
still wrong. […]
Hi Patrick, i think VENDOR field would not be right to say if BIOS is coreboot ? Please have a look at this kernel driver we have used : https://github.com/thesofproject/linux/pull/2786
We have DMI match for VENDOR And NAME. We differenciate based on both fields. When Google boards say VENDOR as GOOGLE, Intel boards should mention it as INTEL rather than coreboot.
some more examples of how these fields are used in another driver: https://github.com/torvalds/linux/blob/master/sound/soc/intel/boards/sof_rt5...
I might have less knowledge here, but in DMI we have 2 sections, SMBIOS information and SYSTEM information. Can we have VENDOR field in both sections and 1 can be coreboot and 1 can be INTEL ?
THoughts ?