7 Jun
2020
7 Jun
'20
11:45 a.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42141 )
Change subject: ec/google/wilco: Fix comment about enclosure type ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42141/1/src/ec/google/wilco/acpi/vb... File src/ec/google/wilco/acpi/vbtn.asl:
https://review.coreboot.org/c/coreboot/+/42141/1/src/ec/google/wilco/acpi/vb... PS1, Line 8: * have SMBIOS_ENCLOSURE_CONVERTIBLE for the SMBIOS enclosure type to
IMHO, this makes it too tempting to manually set the SMBIOS enclosure type for this code to work. […]
My proposal is to drop SYSTEM_TYPE_xx Kconfig.
--
To view, visit https://review.coreboot.org/c/coreboot/+/42141
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib658af7b80586428b22f08a738964637e1fbd17a
Gerrit-Change-Number: 42141
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 07 Jun 2020 18:45:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment